Upgrading to nb-javac from JDK 27b23#9413
Open
lahodaj wants to merge 18 commits into
Open
Conversation
lahodaj
added
Java
Member
|
suggestion: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 20f9322..b94eb02 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -1470,10 +1470,10 @@
timeout-minutes: 60
strategy:
matrix:
- java: [ '21', '26' ]
+ java: [ '21', '27-ea' ]
config: [ 'batch1', 'batch2' ]
exclude:
- - java: ${{ github.event_name == 'pull_request' && 'nothing' || '26' }}
+ - java: ${{ github.event_name == 'pull_request' && 'nothing' || '27-ea' }}
fail-fast: false
steps:the hints job was skipped in #9402 since it had to wait for the nb-javac update |
…ne independently, if at all.
…PIs are resolved as needed.
Member
|
i think the cleanup job failure can be ignored. The required permission seems to be only propagated after rebase. Detailsshould be edit: reverted to the old action, should work again |
Member
|
indexer smoke test worked, but there seems to be performance regression somewhere however, the smoke test (which opens all NB modules and waits for indexer) isn't great for benchmarks since the order the projects load isn't fixed i believe. A single big project would be better. |
Contributor
Author
|
I did a few runs, and I don't think (or at least don't see) a real regression. On master, if I do: I get, for example: which totals to ~672s. I.e. there are multiple indexing happening. If I did the same with this branch, I got: which totals to ~659s. But I've seen a different numbers in different runs, we just can't (sadly) take the last and/or biggest number, I think. Unless we can somehow make sure everything is opened and setup and only then indexing starts(?). Or do I miss something? |
Member
|
yeah we would need a better benchmark to track indexer performance. I used the NB repo as smoke test for the indexer since it did find issues in past. But it isn't great for benchmarks since I believe the scan order won't be deterministic. Lets ignore that for now. But good that you got more consistent results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)